[MGNLUI-3864] Allow multiple reorder actions with keyboard on MultiValueField Created: 27/Apr/16 Updated: 09/Feb/17 Resolved: 15/Sep/16 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | dialogs, forms |
| Affects Version/s: | 5.4.5 |
| Fix Version/s: | 5.4.10, 5.5 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Nickolaus Wing | Assignee: | Hieu Nguyen Duc |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | multifield, quickwin, usability | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 1d 1.5h | ||
| Original Estimate: | 2d | ||
| Template: |
|
| Patch included: |
Yes
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: | |
| Sprint: | Saigon 61 |
| Story Points: | 3 |
| Description |
|
We just noticed you added re-ordering to the MultiValueFieldDefinition. It's great to have! We had already implemented it on our own, so we are going to eliminate our subclass and use yours. The only thing we did that you didn't was the following: When you use keyboard navigation to tab over to one of the move up or move down links, and activate the link, it loses focus. So if I want to move something up three spaces, now I need to tab all the way down to the link two more times. Instead we should just maintain focus on the same link so you can activate the link 3 times and you're done. Hopefully that's a clear explanation. I'm including a really simple patch against today's trunk to illustrate. Untested but it's dead simple and really close to what we did in our implementation. |
| Comments |
| Comment by Nickolaus Wing [ 28/Apr/16 ] |
|
Removed the attached patch file because I made a pull request instead. Now is as good a time as any to figure out your pull request system. |
| Comment by Mikaël Geljić [ 05/Sep/16 ] |
|
Thanks Nickolaus, we're gonna take a look. @DevTeam let's check out the PR, make necessary changes (either code and/or code style), and eventually add a test (unit or UI, whichever makes more sense). Thanks a lot! |