[MGNLUI-3868] Allow to provide a custom editor callback when creating a dialog Created: 29/Apr/16 Updated: 09/Feb/17 Resolved: 05/May/16 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | framework |
| Affects Version/s: | None |
| Fix Version/s: | 5.4.7, 5.5 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Roman Kovařík | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Sprint: | Kromeriz 42 | ||||||||
| Story Points: | 3 | ||||||||
| Description |
|
We can go to the next dialog when chaining dialogs and the related item doesn't have to be saved into JCR yet. This results into two problems:
Found after integration of |
| Comments |
| Comment by Mikaël Geljić [ 03/May/16 ] |
|
| Comment by Roman Kovařík [ 03/May/16 ] |
It tries to expand the parent node if the new node doesn't exist. It logs an error (in info.magnolia.ui.workbench.tree.HierarchicalJcrContainer#getParent) if you do it on the root level since the root node isn't part of the container. This is another bug than firing the event unnecessary twice. |
| Comment by Mikaël Geljić [ 03/May/16 ] |
|
Yup, it's another thing, it depends how we see it because if we fix it, then firing the event twice would no longer be an issue |
| Comment by Roman Kovařík [ 04/May/16 ] |
|
Separate ticket: |
| Comment by Mikaël Geljić [ 04/May/16 ] |
|
Sure, thanks for filing |