[MGNLUI-3883] Dialogs have Cancel and Save Changes actions by default Created: 18/May/16  Updated: 09/Feb/17  Resolved: 02/Nov/16

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 5.5

Type: Story Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Philip Mundt
Resolution: Outdated Votes: 0
Labels: devwl
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MGNLUI-4022 Move dialog actions from ui-admincent... Closed
depends upon MAGNOLIA-6790 Implement changing all properties wit... Closed
supersession
supersedes MAGNOLIA-6456 Dialogs should have a default actions... Closed
is superseded by MGNLUI-4058 Dialogs have Cancel and Save actions ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: LD: Fundamental features
Sprint: Kromeriz 65, Basel 68
Story Points: 5

 Description   

Note

This solution was not accepted and therefore was reverted (see comment below).
Superseded by https://jira.magnolia-cms.com/browse/MGNLUI-4058

Description

If a dialog does not supply an actions node in its definition, then the Cancel and Save Changes actions should be provided by default.
If a dialog does supply an actions node - then only the actions specified should be provided.

Reason: These same actions are used in most dialogs. It is extra effort for developers to always supply them in dialogs, it is something that they can make mistakes with, and it feels like "boilerplate" that must always be added. Evaluators will have a better impression if these same actions are not specified in every dialog definition.

The part of the definition that should be optional:

actions:
  commit:
    class: info.magnolia.ui.admincentral.dialog.action.SaveDialogActionDefinition
  cancel:
    class: info.magnolia.ui.admincentral.dialog.action.CancelDialogActionDefinition


 Comments   
Comment by Christopher Zimmermann [ 27/Oct/16 ]

Description and title should be updated to reflect that this is now just above moving some classes - but no improvements to the dialog are made.

Comment by Philip Mundt [ 02/Nov/16 ]

Commit that introduced info.magnolia.ui.dialog.definition.DefaultActionsDialogDefinition was reverted: https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/commits/4f818fb8175e9b1db6fbbc03b448ed341bbbd9ba

Comment by Philip Mundt [ 02/Nov/16 ]

cmeier solution was not accepted and therefore reverted. Closed and is superseded by MGNLUI-4058.

Comment by Christopher Zimmermann [ 02/Nov/16 ]

Setting resolution to Outdated as all changes were reverted, and the ticket is superceded.

Generated at Mon Feb 12 09:11:04 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.