[MGNLUI-389] Workbench: double click should respect the item type and open the assigned dialog (default action per type) Created: 10/Dec/12  Updated: 14/Jun/13  Resolved: 14/Jun/13

Status: Closed
Project: Magnolia UI
Component/s: configuration, design, dialogs
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Task Priority: Major
Reporter: Eric Hechinger Assignee: Unassigned
Resolution: Duplicate Votes: 0
Labels: apiteam, frontend
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MGNLUI-1294 Change and unify selection and inline... Closed
duplicate
duplicates MGNLUI-1411 Default action should be configureabl... Closed
relation
is related to MGNLUI-478 Can't properly create and edit folder... Closed
is related to MGNLDAM-80 Double click on DAM folder generate e... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Sprint: Beta 2, Beta 3

 Description   

When double clicking on an tree element we should be able to configure the dialog to open:
For example in the asset App:
Double click on a folder should open the folder dialog
Double click on a asset should open the asset sub app dialog.



 Comments   
Comment by Christopher Zimmermann [ 07/Jan/13 ]

It is to be discussed in a concept how this is defined an implemented. But there is some consensus that we probably need to have "default actions" for different node types so that - as mentioned - folder can behave different then item.

Comment by Eric Hechinger [ 08/Jan/13 ]

Currently: Double click is linked to the default action and default action name should be unique --> related to one action.

ContentWorkbenchPresenter.executeDefaultAction() --> ActionbarPresenter.getDefaultActionDefinition()
// considering actionbar item name unique, returning first match
if (!definition.getSections().isEmpty()) {

Comment by Andreas Weder [ 03/May/13 ]

I've reviewed this and related behavior with Pascal. We believe that a double-click should always call a default action defined by item type. If no default action is set (e.g. in the config tree of the Configuration app), the double-click would trigger in-line editing of text fields. More can be found here: http://jira.magnolia-cms.com/browse/MGNLUI-1294

The default action for most items would actually be to open the preview of the item. We once decided that we would no longer open the edit view on a double-click as we want to avoid issues with concurrent editing (among other reasons). Starting with 5.0, a user has to explicitly click on the "edit" action or later switch from preview to edit view to start editing an item.

However, since we don't have the editing flow fully implemented in 5.0 (which means that some item actually miss a preview):

  • For most items, the default action will be to open the edit dialog or edit view of the item
  • If an item has no edit view, we trigger in-line editing of the node name, or the text you double-clicked.
  • Should in-line editing not be available or difficult to implement, we open the rename dialog, as described here: http://jira.magnolia-cms.com/browse/MGNLUI-1295
  • In all other cases, a double-click is ignored.
Comment by Andreas Weder [ 03/May/13 ]

Linking a story describing how double-clicking should call a default action.

Generated at Mon Feb 12 08:36:24 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.