[MGNLUI-3920] Remove changedProperties from adapters upon #removeItemProperty Created: 20/Jun/16 Updated: 29/Jul/16 Resolved: 28/Jul/16 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | vaadin integration |
| Affects Version/s: | None |
| Fix Version/s: | 5.4.8 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Mikaël Geljić | Assignee: | Mikaël Geljić |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | adapters, vaadin | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 1h | ||
| Original Estimate: | 1h | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Sprint: | Saigon 54 | ||||||||
| Story Points: | 3 | ||||||||
| Description |
|
Currently, if we #addItemProperty and then #removeItemProperty on the adapter, before saving, it will still try to save the changed property (it's not removed from the map). If we blindly do this, we then run into concurrent access, because #updateProperty (internal API) also calls #removeItemProperty (public Vaadin API) when value is blank. Then it's too late to act upon #changedProperties so we need to mark properties for deletion "internally" as well. Use case/story: |