[MGNLUI-3960] Tab definitions without a field create NPE in FormPresenter Created: 22/Jul/16  Updated: 09/Feb/17  Resolved: 09/Aug/16

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.4.7
Fix Version/s: 5.4.9, 5.5

Type: Bug Priority: Critical
Reporter: Frank Sommer Assignee: Ilgun Ilgun
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 40m
Original Estimate: Not Specified

Issue Links:
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Basel 56
Story Points: 3

 Description   

It is not possible to have empty dialog tabs in Magnolia 5.4.7. With Magnolia 5.3.14 empty tabs are hidden in dialogs. Now the following NPE is logged and the dialog could not be opened.

Caused by: java.lang.NullPointerException: null value in entry: info.magnolia.ui.form.definition.ConfiguredTabDefinition@6ae197c=null
        at vom.google.common.collect.CollectPreconditions.checkEntryNotNull(CollectPreconditions.java:33)
        at com.google.common.collect.RegularImmutableMap.<init>(RegularImmutableMap.java:88)
        at com.google.common.collect.ImmutableMap.copyOf(ImmutableMap.java:294)
        at com.google.common.collect.Maps.toMap(Maps.java:1121)
        at com.google.common.collect.Maps.toMap(Maps.java:1097)
        at info.magnolia.ui.dialog.formdialog.FormPresenterImpl.presentView(FormPresenterImpl.java:117)
        at info.magnolia.ui.dialog.formdialog.FormDialogPresenterImpl.buildView(FormDialogPresenterImpl.java:167)
        at info.magnolia.ui.dialog.formdialog.FormDialogPresenterImpl.start(FormDialogPresenterImpl.java:152)
        at info.magnolia.module.blossom.dialog.BlossomFormDialogPresenter.start(BlossomFormDialogPresenter.java:91)


 Comments   
Comment by Frank Sommer [ 22/Jul/16 ]

Possible I can fix it, if I override the DefaultDialogCreator implementation, but how can load Blossom my implementation?
@tmattsson Are there other extension points in blossom, to prevent rendering empty dialog tabs?

Comment by Philip Mundt [ 09/Aug/16 ]

Given fix doesn't solve the underlying problem. Same exception still occurs. FormPresenterImpl.this.formView.getFormSections().size() is greater than 0 but rather the List of info.magnolia.ui.form.definition.ConfiguredTabDefinition s contains an empty element.

Generated at Mon Feb 12 09:11:51 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.