[MGNLUI-4022] Move dialog actions from ui-admincentral to ui-dialog module Created: 21/Sep/16  Updated: 09/Feb/17  Resolved: 05/Nov/16

Status: Closed
Project: Magnolia UI
Component/s: admincentral, dialogs
Affects Version/s: None
Fix Version/s: 5.5

Type: Task Priority: Neutral
Reporter: Antonín Juran Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-6840 Fix migration 4.5 → 5.5 and 5.3 → 5.5 Closed
causality
is causing MGNLCMNT-124 Fix migration diff Closed
is causing MGNLUI-4057 DialogMigrationTask uses new package ... Closed
is causing MGNLUI-4062 Migration from 5.3 to 5.5 causes migr... Closed
dependency
is depended upon by MGNLUI-3883 Dialogs have Cancel and Save Changes ... Closed
is depended upon by MGNLUI-4058 Dialogs have Cancel and Save actions ... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Sprint: Kromeriz 65, Kromeriz 69
Story Points: 0

 Description   

CancelDialogAction.java
CancelDialogActionDefinition.java
SaveConfigDialogAction.java
SaveConfigDialogActionDefinition.java
SaveDialogAction.java
SaveDialogActionDefinition.java
SaveImportDialogAction.java
SaveImportDialogActionDefinition.java



 Comments   
Comment by Evzen Fochr [ 06/Oct/16 ]

create follow-up tickets for pages, form, forum, rssaggregator, dam-app and categorization (at least what i see in ce).

Comment by Roman Kovařík [ 02/Nov/16 ]

Reopened:
Deprecated SaveDialogAction is not compatible, it's using the new definition instead of the deprecated one, see https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/magnolia-ui-admincentral/src/main/java/info/magnolia/ui/admincentral/dialog/action/SaveDialogAction.java
Check also the other actions.
To reproduce, use a custom action which extends the deprecated one.

Caused by: java.lang.NoSuchMethodError: info.magnolia.ui.admincentral.dialog.action.SaveDialogAction.<init>(Linfo/magnolia/ui/admincentral/dialog/action/SaveDialogActionDefinition;Lcom/vaadin/data/Item;Linfo/magnolia/ui/form/EditorValidator;Linfo/magnolia/ui/form/EditorCallback;)V
	at info.magnolia.silverpop.mail.ui.action.PublishToSilverpopAction.<init>(PublishToSilverpopAction.java:81)
	... 131 more
Generated at Mon Feb 12 09:12:29 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.