[MGNLUI-4027] Remove adminInterface-legacy module. Created: 22/Sep/16  Updated: 09/Feb/17  Resolved: 18/Oct/16

Status: Closed
Project: Magnolia UI
Component/s: admincentral
Affects Version/s: None
Fix Version/s: 5.5

Type: Task Priority: Neutral
Reporter: Michael Mühlebach Assignee: Maxime Michel
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1.5d
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-4063 Fix Migration diffs caused by AdminIn... Closed
dependency
depends upon MGNLRES-288 Remove references to adminInterface-l... Closed
depends upon MGNLTPLSMPL-25 Remove references to adminInterface-l... Closed
depends upon MGNLFORUM-293 Remove dependency on admininterface-l... Closed
is depended upon by MGNLCE-58 Remove Maven dependency on admininter... Closed
relation
is related to MGNLUI-4033 Double-check that there are no missin... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Release notes required:
Yes
Date of First Response:
Epic Link: Phase out Admin-interface Legacy
Sprint: Basel 67
Story Points: 8

 Description   

With Magnolia 5.5 adminInterface-legacy will be removed entirely from the bundles, as all the legacy apps (except for DevTools?) have been converted to the new Vaadin-based UI.
Customers can manually add adminInterface-legacy back to their web apps in case they still need it.

ui-admincentral MVH will take care of removing some of the leftovers from adminInterface-legacy (see related issues for other modules doing their part) and eventually remove adminInterface-legacy module itself. In the current 5.5-SNAPSHOT EE pro bundle the following references to old admininterface have been found

config workspace
---
/server/i18n/authoringLegacy
/server/filters/servlets/AdminTreeServlet
/server/filters/servlets/DialogServlet
/server/filters/servlets/PageServlet

/modules/ui-admincentral/apps/websiteJcrBrowser
/modules/ui-admincentral/apps/logViewer
/modules/ui-admincentral/apps/configInfo
/modules/ui-admincentral/apps/export
/modules/ui-admincentral/apps/import
/modules/ui-admincentral/apps/jcrQueryUtils
/modules/ui-admincentral/apps/devTools
/modules/ui-admincentral/apps/permissions
/modules/ui-admincentral/apps/log4j
/modules/ui-admincentral/config/appLauncherLayout/groups/dev/apps/devTools
/modules/ui-admincentral/templates/deleted@i18nBasename


/modules/jcr-browser-app/apps/jcr-browser/subApps@extends value must change to /modules/ui-admincentral/apps/configuration/subApps

/modules/adminInterface

userroles workspace
---
// found with  select * from [nt:base] as n where n.path like '%/.magnolia/pages/%’

/security-base/acl_uri/02
/security-base/acl_uri/03
/security-base/acl_uri/04
/security-base/acl_uri/05
/security-base/acl_uri/06
/security-base/acl_uri/07
/security-base/acl_uri/08
/security-base/acl_uri/00

//from forum module
/forum_ALL-admin/acl_uri/0
/forum_ALL-user/acl_uri/0
/forum_ALL-moderator/acl_uri/0

// found by searching in JCR app for '*admininterface*'
//from resources module
/resources-base/acl_config/02
/resources-base/acl_config/01
/resources-base/acl_config/03

//from templating samples module
/editor/acl_config/03
/developer/acl_config/01
/editor/acl_config/00
/developer/acl_config/00
/editor/acl_config/0

// all other workspaces seem to contain no reference to admininterface

More references in module descriptors

Some of the above should be removable safely. Subtasks will be created for that if needed.

  • Legacy messages.properties in ui-admincentral can be removed as well.


 Comments   
Comment by Ilgun Ilgun [ 06/Oct/16 ]

Reverted due to selenium test failures

Comment by Philip Mundt [ 18/Oct/16 ]

This whole configuration from admininterface-legacy has been forgotten:

<servlet>
  <name>FCKEditorSimpleUploadServlet</name>
  <class&gt;info.magnolia.module.fckeditor.servlets.FCKEditorSimpleUploadServlet</class&gt;
  <comment>Used for fckeditor inline images and files</comment>
  <mappings>
    <mapping>/.magnolia/fckeditor/upload</mapping>
  </mappings>
  <!-- ... -->
</servlet>

Resulting in an exception on a migrated instance:

2016-10-18 11:09:41,979 WARN  magnolia.jcr.node2bean.impl.Node2BeanProcessorImpl: Can't set property [servletClass] to value [info.magnolia.module.fckeditor.servlets.FCKEditorSimpleUploadServlet] in bean [info.magnolia.cms.filters.ServletDispatchingFilter] for node [/server/filters/servlets/FCKEditorSimpleUploadServlet] due to: [info.magnolia.jcr.node2bean.Node2BeanException: Can't convert property. Class for type [class java.lang.Class] not found.]
info.magnolia.jcr.node2bean.Node2BeanException: Can't convert property. Class for type [class java.lang.Class] not found.
Comment by Philip Mundt [ 18/Oct/16 ]
More leftovers

Permission:

<path>/.resources/fckeditor*</path>
<permissions>0</permissions>

Permission node in:
/ui-admincentral/config/appLauncherLayout/groups/tools/apps/permissions

Comment by Philip Mundt [ 25/Oct/16 ]

Tested by upgrading ee-pro-demo from 5.4.9 to 5.5-SNAPSHOT. Except the expected i18n issue (tackled in MGNLUI-4033) everything seemed to work. Also see diff reports from:

Generated at Mon Feb 12 09:12:32 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.