[MGNLUI-403] AppContext should not expose functionality internal to AppContextImpl and AppControllerImpl Created: 11/Dec/12 Updated: 08/Jul/15 Resolved: 14/Feb/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | app framework |
| Affects Version/s: | None |
| Fix Version/s: | 5.0 |
| Type: | Task | Priority: | Major |
| Reporter: | Tobias Mattsson | Assignee: | Espen Jervidalo |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | app-api, framework | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||
| Description |
|
The idea of AppContext is to expose functionality to the App. That is, to an instance of an app. It should not expose methods that are only used by AppControllerImpl. These should be hidden from all other classes. If necessary AppControllerImpl#runningApps should be changed to <String, AppContextImpl>. Also if the intention of AppContextImpl is unclear it should be renamed to reflect the fact that is not just the default implementation of AppContext, it does much more and in fact fullfils much of the contract defined by AppController. |
| Comments |
| Comment by Espen Jervidalo [ 29/Jan/13 ] |
|
would it maybe make sense to rename the AppController to AppLauncher or similar, introduce a new AppController class which takes care of the contract to the AppLauncher and keep the AppContext as thin as possible, only serving contextual information to the actual App? |
| Comment by Espen Jervidalo [ 14/Feb/13 ] |
|
fixed on app-api branch |