[MGNLUI-405] AppDescriptorRegistry only fires change events when name, enabled, icon or app class is changed Created: 13/Dec/12  Updated: 27/Jul/17  Resolved: 27/Jul/17

Status: Closed
Project: Magnolia UI
Component/s: app framework
Affects Version/s: 5.0
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Tobias Mattsson Assignee: Unassigned
Resolution: Outdated Votes: 0
Labels: framework
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-3380 App launcher layout reloading mechani... Accepted
Template:
Acceptance criteria:
Empty
Task DoR:
Empty

 Description   

When you change configuration of an app, for instance within a sub app or its permissions or something else the AppDescriptorRegistry does not fire events. It only fires event if any of name, enabled, icon or appClass is change.

AppDescriptorRegistry performs checks on the app providers it has registered in order to send very fine grained events. It relies on providers implementing the equals method to compare them as they are registered. These fine grained events are all processed identically and so don't seem to be necessary.

Simplifying this would mean that we instead of firing REGISTERED,REREGISTERED,UNREGISTERED would fire a single event meaning that the set of app descriptors has changed.

This concerns the classes:

  • info.magnolia.ui.framework.app.registry.AppDescriptorRegistry
  • info.magnolia.ui.framework.app.registry.AppRegistryEvent
  • info.magnolia.ui.framework.app.registry.AppRegistryEventType
  • info.magnolia.ui.framework.app.registry.AppRegistryEventHandler


 Comments   
Comment by Tobias Mattsson [ 29/Apr/13 ]

Actually, the REREGISTERED event is only sent if the apps name, icon, class or enabled flag is changed. If you for instance do configuration changes on a sub app no event is dispatched. The registry though is still updated.

Comment by Tobias Mattsson [ 23/May/13 ]

When implementing support for access control of apps MGNLUI-1283, I've realised that the app launcher does not reload as the access is configured. Simplifying these events would fix this.

Comment by Tobias Mattsson [ 23/May/13 ]

If we change this, there's going to be a lot more events fired and the app launcher will reload for each and every one of them unless it checks first if reloading would change anything.

Generated at Mon Feb 12 08:36:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.