[MGNLUI-4057] DialogMigrationTask uses new package for (Save+Cancel)DialogActionDefinition and causes migration diffs Created: 27/Oct/16  Updated: 31/Oct/16  Resolved: 27/Oct/16

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 5.5

Type: Bug Priority: Neutral
Reporter: Philip Mundt Assignee: Philip Mundt
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-6840 Fix migration 4.5 → 5.5 and 5.3 → 5.5 Closed
causality
caused by MGNLUI-4022 Move dialog actions from ui-admincent... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Fix migration 4.5 → 5.5 and 5.3 → 5.5
Sprint: Basel 67
Story Points: 1

 Description   

info.magnolia.ui.dialog.setup.DialogMigrationTask was used in post-4.5 era to migrate legacy dialogs to the new UI. The task is mainly used in modules' MVH of that time, for example standard-templating-kit version 2.5 would migrate its dialogs using this task.

In MGNLUI-4022 this legacy task was updated to use the new packages of the moved SaveDialogActionDefinition and CancelDialogActionDefinition! (info.magnolia.ui.dialog.action.SaveDialogActionDefinitioninfo.magnolia.ui.admincentral.dialog.action.SaveDialogActionDefinition).

This causes migrated instances to already contain the new actions when migrating from 4.5 to 5.5!

Instead, this task should not have been touched. We should maybe create a new task for the pupose of updating the action (if necessary at all, there is info.magnolia.module.delta.ChangeAllPropertiesWithCertainValueTask)!?

Task

Partially revert changes made to info.magnolia.ui.dialog.setup.DialogMigrationTask.



 Comments   
Comment by Ilgun Ilgun [ 31/Oct/16 ]

Fixed the migration diff -> https://jenkins.magnolia-cms.com/view/Migration/job/int_migration-tests_4.5-to-5.5.x-pro-demo-stk-branch

Generated at Mon Feb 12 09:12:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.