[MGNLUI-408] Refactor ActionbarPresenter for better testability Created: 14/Dec/12 Updated: 21/Nov/13 Resolved: 19/Jun/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 5.0 |
| Fix Version/s: | 5.0 |
| Type: | Task | Priority: | Major |
| Reporter: | Daniel Lipp | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||
| Description |
|
Current implementation of ActionbarPresenter doesn't allow Unit-Test for many methods and makes it very complicated for others (u have to provided a full ActionbarDefinition although this is only used to instantiated ActionbarViews). First step to fix this issue: don't create ActionbarView (via calling ActionbarBuilder.build(definition)) in #start(ActionbarDefinition, ActionFactory) but pass it as a third parameter in the #start method |