[MGNLUI-4084] Tree scroll position is not properly maintained (Firefox/Chrome) Created: 22/Nov/16 Updated: 10/Dec/19 Resolved: 31/Jan/17 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | tree/list |
| Affects Version/s: | 5.4.6, 5.5 |
| Fix Version/s: | 5.3.18, 5.4.11, 5.5.2 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Mikaël Geljić | Assignee: | Hieu Nguyen Duc |
| Resolution: | Fixed | Votes: | 5 |
| Labels: | chrome, firefox, scroll, tree | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 2d 5h | ||
| Original Estimate: | 6d | ||
| Environment: |
Firefox 49–50 |
||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||
| Sprint: | Saigon 79, Saigon 80, Saigon 81 | ||||||||||||||||||||||||||||||||||||
| Story Points: | 8 | ||||||||||||||||||||||||||||||||||||
| Description |
|
Trees have become less usable in Firefox "lately"—especially there seems to be an increase of "jumping" issues. When using inplace-editing below the fold (in config-app)
When using the context menu below the fold (via sang.ngo, thanks for reporting)
notes
[1] I suspect the RowScroller to come into play here somehow
Update 2016.12.28Chrome now suffers as well from scrolling back to top, albeit slightly differently:
upon any "indirect selection changes",
|
| Comments |
| Comment by Maxime Michel [ 15/Dec/16 ] |
|
Thanks for the investigation, this is terrible. |
| Comment by Mikaël Geljić [ 28/Dec/16 ] |
|
viet.nguyen Thanks for the update; indeed Chrome got worse since I last tested it—it's also not affected exactly in the same ways. I added an update section to the issue description and clarified:
|
| Comment by Hieu Nguyen Duc [ 18/Jan/17 ] |
|
I've tested on Chrome 55.0.2883.95 (64-bit), Firefox 50.1.0 and IE11.0.96xxx. Some problems don't happen in IE11:
I've also tried to disable TreeRowScroller in TreeViewImpl and the bugs still happen. |
| Comment by Mikaël Geljić [ 30/Jan/17 ] |
|
Thank you hieu.nguyen for your PR, you got it right; I first doubted -webkit based properties would have any impact on Firefox, but believe it or not, they do. Here's the summary of the overall investigation: The issue indeed came from our admincentral theme, where we turned on hardware-accelerated CSS transforms for tables/trees, back in
|
| Comment by Mikaël Geljić [ 31/Jan/17 ] |
|
Release notes (cc. mdrapela):
|
| Comment by Frank Sommer [ 31/Jan/17 ] |
|
@mgeljic: Is there a way to hotfix this without upgrading the whole Magnolia application? |
| Comment by Mikaël Geljić [ 31/Jan/17 ] |
|
frank.sommer, I guess there is. Either patch the precompiled styles.css from the admincentral theme from magnolia-ui-admincentral.jar!/VAADIN/themes/admincentral/styles.css, or recompile it from the Scss source. New theme should be put on the classpath at /VAADIN/themes/yourThemeName/styles.css. That should do the trick. |
| Comment by Vikas Attiguppa [ 31/Jan/17 ] |
|
Hi, We are having the same issue we are using 5.3.8 and i tried the patch method where in i copied the magnolia-ui-admincentral.jar!/VAADIN/themes/admincentral/styles.css text into a new style.css and removed the couple of lines that need to be deleted and put the file into our class path at /VAADIN/themes/Theme_name/styles.css. It does not seem to fix the issue. Is this the right way to do it? |
| Comment by Richard Gange [ 01/Feb/17 ] |
|
Hi Vikas- It sounds to me that you are trying to mix the 2 approaches. I provided you a patched version of magnolia-ui-admincentral jar on the support ticket. Could you give that a try? Thanks |
| Comment by Mikaël Geljić [ 01/Feb/17 ] |
|
I also confirm the theme approach does the trick. I just applied it to a 5.3 bundle, extracted the stylesheet, patched it and put it back into WEB-INF/classes into a renamed theme directory, eventually reconfigured in magnolia.properties. The top-scrolling issues was gone; |
| Comment by Ronald Ten Berge [ 30/Nov/17 ] |
|
Hi, This bug seems to be back on Magnolia 5.6 in combination with FireFox 57.0 (64bit). |
| Comment by Karsten Martin [ 05/Dec/17 ] |
|
Hi, can confirm for Magnolia 5.5.6 as well. greetings |
| Comment by Mikaël Geljić [ 07/May/18 ] |
|
Hi karsten.martin, rtenberge, So far we have been unable to reproduce the issue; does it still affect you? Would you mind shedding more details about the scenario and setup? In particular:
Many thanks, |
| Comment by Bradley Andersen [ 30/Jan/19 ] |
|
Issue re-reported by Diamond Light Source: Magnolia 5.5.12 / Firefox (64.0.2). Please see http://pvnp.us/IMG_1337.MOV.
|