[MGNLUI-4116] View scrolls back to the beginning upon browsing with Chrome Created: 10/Jan/17  Updated: 06/Feb/17  Resolved: 30/Jan/17

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.3.17, 5.4.7, 5.4.10, 5.5
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Zdenek Skodik Assignee: Mikaël Geljić
Resolution: Duplicate Votes: 2
Labels: None
Remaining Estimate: 2d
Time Spent: 3d
Original Estimate: 5d
Environment:

Chrome 55.0.2883.87, 55.0.2883.95
Not reproducible with Firefox or IE11


Attachments: File Magnolia-use-vaadin-treetable.webm    
Issue Links:
duplicate
duplicates MGNLUI-4084 Tree scroll position is not properly ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Saigon 79, Saigon 80, Saigon 81
Story Points: 8

 Description   

To reproduce (video is attached to the linked ticket):

  • tick a node somewhere in your browser subapp
  • scroll somewhere else so that this node gets out of screen
  • click on some another content there, or try to expand a subtree etc.
  • the view should shift back to the very beginning of the tree


 Comments   
Comment by Ngoc Nguyenthanh [ 20/Jan/17 ]
Steps to reproduce
  • Open Configuration app
  • Select the "/server" node by checking the checkbox on the left side of the item.
  • Scroll down until the selected node is not visible.
  • Try to expand a sub-tree
  • The scroll bar will scroll-up to the beginning of the list

I can reproduce on Vaadin demo site with the same steps aforesaid by access http://demo.vaadin.com/valo-theme/#!trees

More detail

Here is the request data made by a normal expand request and an error request - missing firstvisible
No Error:

{firstvisible=4, toggleCollapsed=6}

{lastToBeRendered=56, firstvisible=4, firstToBeRendered=3, reqfirstrow=17, reqrows=40}

{lastToBeRendered=56, firstvisible=4, firstToBeRendered=0, reqfirstrow=0, reqrows=3}

Error
{firstvisible=4, toggleCollapsed=6}

{lastToBeRendered=56, firstvisible=4, firstToBeRendered=3, reqfirstrow=17, reqrows=40}

{lastToBeRendered=56, firstToBeRendered=0, reqfirstrow=0, reqrows=3}

Some reported issues related to our issue

Try to use TreeTable implementation instead of MagnoliaTreeTable. The table is even more shaky. See attached video.

Comment by Mikaël Geljić [ 27/Jan/17 ]

I managed to reproduce this consistently with the standard Vaadin TreeTable, with the default widgetset, on 7.4.7 (same as M5.4).

  • It happened in both FF and Chrome
  • It happened regardless of where the selection was made—well there's no checkbox in std TreeTable anyway
  • It actually jumped to the viewport containing the current selection; i.e. if you had initial selection below the fold, then it'd still go up, but not to the top.
  • This issue #18247 was fixed in Vaadin 7.5.4, therefore could not be the culprit on M5.5.

On the Magnolia side:

  • The Vaadin issue mentioned above did not affect us, thanks to our patches—especially by overriding/voiding VScrollTable#updateFirstVisibleAndScrollIfNeeded
  • Then hardware-accelerated CSS transforms—from our admincentral theme—started to mess with tables/trees, first making Chrome suffer from these issues.
  • Eventually, Firefox 49+ added support for -webkit prefixed versions of a number of CSS transform properties (wtf), causing troubles there as well.

So this issue is actually the same as I reported on MGNLUI-4084, and will be closed as duplicate.

Generated at Mon Feb 12 09:13:26 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.