[MGNLUI-4194] Generalize code for move-availability (dialog, dnd) Created: 19/Apr/17 Updated: 30/Jun/17 Resolved: 10/May/17 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | content app, workbench |
| Affects Version/s: | None |
| Fix Version/s: | 5.5.4 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Mikaël Geljić | Assignee: | Sang Ngo Huu |
| Resolution: | Incomplete | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 3d 7h | ||
| Original Estimate: | 3d | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | Saigon 92, Saigon 93, Saigon 94, Saigon 95 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
As DEV-477 confirmed: there is redundancy between `DropConstraints` (dnd) and `MovePredicates` (move-dialogs), especially for their JCR implementations. In a first step, we're able to delegate from MovePossibilityPredicates to a new default JCR DropConstraint; |
| Comments |
| Comment by Mikaël Geljić [ 09/May/17 ] |
|
Until
2017-05-09 17:19:48,664 WARN ages.app.dnd.TemplateTypeRestrictionDropConstraint: Failed to resolve target item [] parent
javax.jcr.ItemNotFoundException: Root node doesn't have a parent
...
at info.magnolia.jcr.decoration.ContentDecoratorNodeWrapper.getParent(ContentDecoratorNodeWrapper.java:121)
at info.magnolia.pages.app.dnd.TemplateTypeRestrictionDropConstraint.checkIfAllowedAsChildOfTargetItemParent(TemplateTypeRestrictionDropConstraint.java:128)
at info.magnolia.pages.app.dnd.TemplateTypeRestrictionDropConstraint.allowedAfter(TemplateTypeRestrictionDropConstraint.java:115)
at info.magnolia.ui.contentapp.movedialog.MoveDialogPresenterImpl.isMovePossible(MoveDialogPresenterImpl.java:257)
at info.magnolia.ui.contentapp.movedialog.MoveDialogPresenterImpl.updatePossibleMoveLocations(MoveDialogPresenterImpl.java:236)
at info.magnolia.ui.contentapp.movedialog.MoveDialogPresenterImpl.lambda$start$f3276528$1(MoveDialogPresenterImpl.java:174)
This may not be a blocker, as it's only a log entry and doesn't happen for regular page selection. |
| Comment by Mikaël Geljić [ 10/May/17 ] |
|
Was integrated and partially reverted because of regressions with root-node availability ( The new JcrDropConstraint was kept, along with rebase of other implementations on it. We expect move-predicates to be completely ignored again with |