[MGNLUI-4198] Remove unsupported permutations in GWT widgetsets Created: 26/Apr/17  Updated: 05/Jun/19  Resolved: 05/Jun/19

Status: Closed
Project: Magnolia UI
Component/s: widgetset, widgetset-pro
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Federico Grilli Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

In our widgetsets on master we have permutations for ie8, ie9 and ie10 which we do not support https://documentation.magnolia-cms.com/display/DOCS/Certified+stack#Certifiedstack-Backend:AdminCentralandeditingfunctionality
ie11 and edge are supported through gecko/safari permutations apparently (see http://stackoverflow.com/questions/21442159/user-agent-for-gwt-2-6 and https://groups.google.com/forum/#!topic/google-web-toolkit/-uVGzVRPYIs).

That being said, I guess we could get rid of unsupported permutations thus saving some build time, besides having lighter widgetset jars.



 Comments   
Comment by Mikaël Geljić [ 26/Apr/17 ]

Since 5.4 (Vaadin 7.2+) all 20 permutations are "collapsed" into 1.

com/vaadin/DefaultWidgetSet.gwt.xml
<!-- Since 7.2. Compile all permutations (browser support) into one Javascript 
        file. Speeds up compilation and does not make the Javascript significantly 
        larger. -->
<collapse-all-properties />

Most likely we can get rid of the user.agent property altogether.

Comment by Federico Grilli [ 26/Apr/17 ]

[12:54 PM] Federico Grilli: hmm, just tried locally and compared with nexus artifacts and jenkins builds and it doesn't seem to make much difference. Also, looking at the build logs only one permutation/compilation is happening no matter how many user agents are specified (philosoraptor)
[12:57 PM] Mikaël Geljić: yes, ever since 5.4 (Vaadin 7.2 I think) there is only one permutation by default
[1:01 PM] Mikaël Geljić: meaning most likely we could get rid the user.agent property altogether
[1:02 PM] Federico Grilli: i guess so
[1:17 PM] Federico Grilli: for the records, without user.agent property, compilation happens successfully but info underneath is displayed which doesn't when using user.agent. Not sure if this means text area would not work properly on some browsers. At any rate, I will mention all this in the above ticket and we will see

O]    Computing all possible rebind results for 'com.google.gwt.user.client.ui.impl.RichTextAreaImpl'
[INFO]       Rebinding com.google.gwt.user.client.ui.impl.RichTextAreaImpl
[INFO]          Could not find an exact match rule. Using 'closest' rule <replace-with class='com.google.gwt.user.client.ui.impl.RichTextAreaImplSafari'/> based on fall back values. You may need to implement a specific binding in case the fall back behavior does not replace the missing binding
[INFO]       Rebinding com.google.gwt.user.client.ui.impl.RichTextAreaImpl
[INFO]          Could not find an exact match rule. Using 'closest' rule <replace-with class='com.google.gwt.user.client.ui.impl.RichTextAreaImplSafari'/> based on fall back values. You may need to implement a specific binding in case the fall back behavior does not replace the missing binding
[INFO]       Rebinding com.google.gwt.user.client.ui.impl.RichTextAreaImpl
[INFO]          Could not find an exact match rule. Using 'closest' rule <replace-with class='com.google.gwt.user.client.ui.impl.RichTextAreaImplSafari'/> based on fall back values. You may need to implement a specific binding in case the fall back behavior does not replace the missing binding
[INFO]    Computing all possible rebind results for 'org.vaadin.gwtgraphics.client.impl.SVGImpl'
[INFO]       Rebinding org.vaadin.gwtgraphics.client.impl.SVGImpl
[INFO]          Could not find an exact match rule. Using 'closest' rule <replace-with class='org.vaadin.gwtgraphics.client.impl.SafariSVGImpl'/> based on fall back values. You may need to implement a specific binding in case the fall back behavior does not replace the missing binding
[INFO]       Rebinding org.vaadin.gwtgraphics.client.impl.SVGImpl
[INFO]          Could not find an exact match rule. Using 'closest' rule <replace-with class='org.vaadin.gwtgraphics.client.impl.SafariSVGImpl'/> based on fall back values. You may need to implement a specific binding in case the fall back behavior does not replace the missing binding
[INFO]       Rebinding org.vaadin.gwtgraphics.client.impl.SVGImpl
[INFO]          Could not find an exact match rule. Using 'closest' rule <replace-with class='org.vaadin.gwtgraphics.client.impl.SafariSVGImpl'/> based on fall back values. You may need to implement a specific binding in case the fall back behavior does not replace the missing binding
Generated at Mon Feb 12 09:14:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.