[MGNLUI-4215] Remove Magnolia unsupported browser info message (Replaced by Vaadin) Created: 01/Jun/17 Updated: 08/Feb/18 Resolved: 08/Feb/18 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.6.2 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Cedric Reichenbach | Assignee: | Matjaz Trcek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 1m | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | 1m | ||
| Attachments: |
|
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: | |
| Sprint: | Basel 133 |
| Story Points: | 2 |
| Description |
|
Due to Vaadin message that pop ups before / instead of our own, we are removing the Magnolia version of the message |
| Comments |
| Comment by Antti Hietala [ 12/Oct/17 ] |
|
The message is hard-coded into AdminCentralVaadinServlet Proposed replacement: .append("<h2>Sorry.</h2>")
.append("<p>You're trying to use Magnolia on a browser we currently do not support.</p>")
.append("<p>Check <a href="https://documentation.magnolia-cms.com/display/DOCS/Certified+stack">supported browsers</a> and try again.</p>")
.append("<p>See you soon!</p>")
(You may need to escape quotation marks above. And underline the link.) |
| Comment by Matjaz Trcek [ 06/Feb/18 ] |
|
Our integration of browser requirements is actually preceded with Vaadin supported version requirements, which is the same in regards to IE with minimum requirements of 11. More information here: Due to that after chat with mmichel and ahietala we decided to change the ticket accordingly and leave it as is in the new version of Vaadin |
| Comment by Federico Grilli [ 07/Feb/18 ] |
|
ahietala Only one question after pre integration QA: I was wondering whether the Vaadin message should be customised to a more Magnolia look 'n feel |
| Comment by Antti Hietala [ 07/Feb/18 ] |
|
fgrilli I don't see that applying Magnolia styling to the message would add much value to the user. The default Vaadin style is neutral and pleasant enough. With Resurface, it may in fact be quite close to Magnolia style. |