[MGNLUI-4218] Allow to register shortcuts for actions Created: 02/Jun/17  Updated: 18/Sep/17  Resolved: 13/Sep/17

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 5.6

Type: Improvement Priority: Neutral
Reporter: Evzen Fochr Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 2d 1h
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by CONTTAGS-4 Assign a global keyboard shortcut T t... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: Tagging
Sprint: Kromeriz 111, Kromeriz 112, Kromeriz 113
Story Points: 13

 Description   

Here are some investigation results https://wiki.magnolia-cms.com/display/~efochr/Registering+shortcuts+in+magnolia



 Comments   
Comment by Evzen Fochr [ 05/Sep/17 ]

https://wiki.magnolia-cms.com/pages/viewpage.action?spaceKey=ARCHI&title=2017-09-05+Keyboard+shortcuts%2C+3rd+party+BOM

Comment by Roman Kovařík [ 13/Sep/17 ]

Reopened: doesn't work for multiple items

Comment by Philip Mundt [ 13/Sep/17 ]

This might have a big impact on other modules + the client's code: If someone has a custom BrowserPresenter and that method is private one gets compilation error:

[ERROR] /content-translation-support/magnolia-content-translation-support/src/main/java/info/magnolia/translation/ui/app/TranslationBrowserPresenter.java:[91,18] bindHandlers() in info.magnolia.translation.ui.app.TranslationBrowserPresenter cannot override bindHandlers() in info.magnolia.ui.contentapp.browser.BrowserPresenter
  attempting to assign weaker access privileges; was protected

NOTE: Previously one was not overriding that method, as it was private.

Comment by Roman Kovařík [ 13/Sep/17 ]

It's kind of expected that you might have to update the code when you increase the UI version, right?
There shouldn't be a problem at runtime so I don't see a big impact.

Generated at Mon Feb 12 09:14:28 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.