[MGNLUI-4249] When populating UI component bindings the algorithm should not bail out on unresolved apps/sub-apps Created: 11/Jul/17 Updated: 02/Aug/17 Resolved: 31/Jul/17 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 5.5.5 |
| Fix Version/s: | 5.5.6, 5.6 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||
| Date of First Response: | |||||
| Sprint: | Basel 106, Basel 107 | ||||
| Story Points: | 2 | ||||
| Description |
|
When parsing/populating the app and sub-app components we are trying to match the component group id against some registered app. For example: <components> <id>app-foo</id> .... Would match against app foo (if it is present in the app descriptor registry). <components> <id>app-foo-bar</id> .... Would match against the sub-app bar of app foo. Currently, if app is not present in the registry (i.e. there's no such app foo in the app descriptor registry), the collector of the components will bail and cause the whole IoC preparation process to halt, which something that we should clearly avoid. The attached PR prevents an exception from being thrown, rather logs the warning that components mapped to an non-registered app and carries on with bindings population. |