[MGNLUI-4310] Vaadin 8 communication protocol opts causes crop tool to be disabled Created: 23/Oct/17 Updated: 14/Feb/18 Resolved: 23/Oct/17 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 5.6 |
| Fix Version/s: | 5.6 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Sprint: | Basel 119 |
| Story Points: | 2 |
| Description |
|
Crop tool is always disabled after migration to Vaadin 8. After quick investigation it turned out that enable-state checks on the client-side yield incorrect values because enabled property is no longer present on the client-side. My guess is that it happens cause true is the default value of the enabled-state and Vaadin does not communicate that to the client-side at all! Sounds like a not correct behaviour by Vaadin (cause on the client-side the property ends up to be undefined!) The fix anyway would be to introduce a dedicated function in the crop tool connector that'd check if enabled property is explicitly set to false. |