[MGNLUI-4326] Remove setting content-deposition manually to properly encode special characters in filename Created: 22/Nov/17  Updated: 18/May/18  Resolved: 10/Apr/18

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.6
Fix Version/s: 5.6.5

Type: Bug Priority: Neutral
Reporter: Jonathan Ayala Assignee: Leah Staniorski
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screen Shot 2017-11-22 at 12.45.56.png    
Issue Links:
causality
is causing MAGNOLIA-7310 XML Exports open directly in browser ... Closed
duplicate
is duplicated by MGNLDAM-681 special characters in filenames brea... Closed
relation
is related to MGNLCE-269 Create UI test for download of file n... Accepted
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Basel 136, Basel 137, Basel 138, Basel 139, Basel 141
Story Points: 3

 Description   

When uploading a file that contains special characters like Chinese ones in its name to DAM then when downloading or selecting the file, it's name is resolved as empty or ---- because we are manually setting the content-deposition without the proper encoding. Vaadin has default behavior to properly encode the filename in the content-deposition header. If we remove our setting of this header it should work as expected. This is also the case for exporting the files and needs to be fixed.

For example: uploading 啊啊.pdf file, we would get --.pdf

See linked ticket for more details.



 Comments   
Comment by Federico Grilli [ 04/Apr/18 ]

Put on  hold: to be integrated after 5.6.4 release.

Comment by Matjaz Trcek [ 12/Apr/18 ]

QA'd it now and works as expected, thanks for extra explanation ahietala , it helped. 

Comment by Roman Kovařík [ 10/May/18 ]

Can we change the title/description? It's not clear that the content-disposition header is not set anymore.

Generated at Mon Feb 12 09:15:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.