[MGNLUI-4344] IdentifierToPathConverter is marked as deprecated in definition-app Created: 09/Jan/18 Updated: 25/Jan/18 Resolved: 25/Jan/18 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 5.6.1 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christoph Meier | Assignee: | Unassigned |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | vaadin8 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||
| Date of First Response: | |||||
| Description |
|
info.magnolia.ui.form.field.converter.IdentifierToPathConverter extends com.vaadin.v7.data.util.converter.Converter which has become deprecated (with Vaadin8?). The definition app reports this as a minor problem: Configuration was evaluated to a deprecated type: [info.magnolia.ui.form.field.converter.IdentifierToPathConverter] due to deprecated parent type: [com.vaadin.v7.data.util.converter.Converter] |
| Comments |
| Comment by Mikaël Geljić [ 09/Jan/18 ] |
|
We could maybe afford to change type hierarchy there, in favor of a mere Function<String,String>; then wrap with an ad-hoc legacy v7 Converter in the factory. Would be config-compatible, not binary- though. —and/or should anybody inherit from this class; we may have additional type-checks to support both a function or a legacy Converter. |