[MGNLUI-4398] Resurface field types: expandable text field Created: 12/Apr/18 Updated: 08/Aug/18 Resolved: 05/Jun/18 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.0 |
| Type: | Story | Priority: | Neutral |
| Reporter: | Anja von Gunten | Assignee: | Dai Ha |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 2d 3h | ||
| Time Spent: | 1d 1h | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: | |
| Epic Link: | Resurface theme |
| Sprint: | Saigon 146 |
| Story Points: | 5 |
| Description |
|
Current field https://documentation.magnolia-cms.com/display/DOCS56/Expandable+text+field Update: we decided to drop the "horizontal/full-screen" expansion of text areas. This will not be supported in Resurface UI. This ticket is *only* about the vertical expansion, as featured in the Stories app. |
| Comments |
| Comment by Dai Ha [ 17/May/18 ] |
|
mgeljic, I have tried vaadin-compatibility-expandingtextarea but it doesn't seem to work :|, my steps:
For the "other add-ons" that I mentions: https://github.com/ilgun/ExpandingTextArea, it worked, my steps:
I also attach class hierarchy for comparison. |
| Comment by Mikaël Geljić [ 17/May/18 ] |
|
My guess is that ilgun's fork was before we automated the process within our vaadin-compatibility-addons repo. They should be equivalent, aren't they? |
| Comment by Dai Ha [ 17/May/18 ] |
|
I hoped they the same but no, what we are having with compatibility does not work (at least with my trials) |
| Comment by Ilgun Ilgun [ 17/May/18 ] |
|
It's the same as https://git.magnolia-cms.com/projects/PLATFORM/repos/vaadin-compatibility-addons/browse/vaadin-compatibility-expandingtextarea as far as I remember. What doesn't work exactly? dai.ha |
| Comment by Dai Ha [ 18/May/18 ] |
|
ilgun, as mentioned above, my steps are:
With a new org.vaadin.hene.expandingtextarea.ExpandingTextArea, I observed two things:
ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /Users/dai.ha/sources/resurface/resurface-poc/src/main/java/info/magnolia/ui/components/TextComponentUI.java:[110,47] cannot access com.vaadin.v7.data.Property class file for com.vaadin.v7.data.Property not found Converted version of ExpandingTextArea could be found here: https://git.magnolia-cms.com/users/dai.ha/repos/expandingtextarea/browse |
| Comment by Mikaël Geljić [ 18/May/18 ] |
|
dai.ha make sure you have com.vaadin:vaadin-compatibility-server if the addon is using some older v7 data classes. |
| Comment by Ilgun Ilgun [ 18/May/18 ] |
|
dai.ha In github project, namespace is different, com.github.ilgun.expandingtextarea. You were most likely using the original ExpandingTextArea |
| Comment by Dai Ha [ 21/May/18 ] |
|
mgeljic, ilgun vaadin-compatibility-expandingtextarea is working now. Thank you |