[MGNLUI-4438] New theme post-PoC polishing Created: 25/May/18  Updated: 23/Aug/18  Resolved: 04/Jun/18

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0

Type: Task Priority: Neutral
Reporter: Maxime Michel Assignee: Maxime Michel
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLUI-4483 Resurface: chooser dialog Closed
relation
is related to MGNLUI-4568 As a UI developer, I would like to cr... Closed
is related to MGNLUI-4429 Bring new theme into Magnolia Closed
is related to MGNLUI-4596 Resurface polishing: grid Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Epic Link: Resurface theme
Sprint: Basel 148
Story Points: 5

 Description   
  • double-check resurface-poc to make sure nothing was forgotten (validation, grid columns) 
  • in the grid, up and down arrows should gray out the rows
  • in textfield.scss, this line causes compilation problems: $v-textfield-background-color–readonly: 
  • Natasha's comment (MGNLUI-4394

Grid checkboxes (addition to original scope)

After discussing with sgasa I spent some time trying to make the grid closer to current Magnolia's UX. What happened is:

  1. with the default Vaadin 8 grid, CMD/CTRL + click selection isn't supported, see https://github.com/vaadin/framework/issues/6395
  2. it is still possible to select multiple rows by dragging the mouse in the checkboxes column, however:
    1. people will not use this if they don't know the trick
    2. there is no reason why they would know it, as current Magnolia doesn't support it
  3. CMD/CTRL + click can be added through the Grid Extensions add-on, as said in the link above. Problem: this removes checkboxes completely.
  4. while this solves the 'Select All' checkbox issue, it might be a bit harsh to newbies. avongunten says we need to discuss it. We could also add a hacky checkbox to mimic completely the current Magnolia, but that would be more work.


 Comments   
Comment by Maxime Michel [ 04/Jun/18 ]

The grid selection mechanism that is currently implemented actually ressembles one wanted by Andreas, says apchelintcev. So I'm not changing that until we get a chance to discuss it with UX.

Comment by Maxime Michel [ 04/Jun/18 ]

Closing the issue as done. The two warning signs indicate subtasks that I couldn't completely finish. But they will caught under different umbrellas (general polishing, or the 'source of truth' repository meeting on Wednesday for instance).

Comment by Maxime Michel [ 06/Jun/18 ]

The grid UX still isn't 100% satisfying but let's move on.

To avongunten the main issue is that when using the keyboard up/down arrows, the new row doesn't get the focus. Which then means there are three possible states for a row: selected (black), hovered with the mouse (grey), pre-selected with the keyboard (grey).

Also of interest are the keyboard shortcuts, which aren't intuitive to most. For instance, despite working on the grid for two weeks, I only discovered by accident that current row can be selected/unselected as in current Magnolia. Only it doesn't take a regular click, but a Ctrl added to it. Another example is avongunten who wanted to find out how to select/unselect a row with the keyboard, but couldn't. This is going to need some communication from our side.

Generated at Mon Feb 12 09:16:37 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.