[MGNLUI-4525] Wrong logic for customized fieldTypes warning during 5.7 upgrade Created: 25/Jul/18 Updated: 30/Jul/18 Resolved: 26/Jul/18 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | framework |
| Affects Version/s: | None |
| Fix Version/s: | 5.7.1 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Mikaël Geljić | Assignee: | Mikaël Geljić |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 7h | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Sprint: | Saigon 150 | ||||||||||||||||
| Story Points: | 1 | ||||||||||||||||
| Description |
|
Upon upgrading to 5.7, fieldTypes are removed from JCR config and replaced by YAML ones. There is supposedly a warning if either definitionClass or factoryClass is different from our expected default mappings (i.e. if it was customized). Well... currently the logs and install screen are filled with false positives, because the conditions logic is inverted (see info.magnolia.ui.framework.setup.RemoveFieldTypeDefinitionsFromJcrTask:96), and consequently the actual warnings for such valid customization cases are missing. Also visible at:
2018-07-10 11:04:42,469 WARN info.magnolia.module.InstallContextImpl : [0/6 tasks - Magnolia UI Framework (version 5.7.1-SNAPSHOT)]> Field type definition class is different from default one. Expected: [info.magnolia.ui.form.field.definition.BasicUploadFieldDefinition], got: [info.magnolia.ui.form.field.definition.BasicUploadFieldDefinition] in [basicUpload]. 2018-07-10 11:04:42,470 WARN info.magnolia.module.InstallContextImpl : [0/6 tasks - Magnolia UI Framework (version 5.7.1-SNAPSHOT)]> Field type factory class is different from default one. Expected: [info.magnolia.ui.form.field.factory.BasicUploadFieldFactory], got: [info.magnolia.ui.form.field.factory.BasicUploadFieldFactory] in [basicUpload]. 2018-07-10 11:04:42,471 WARN info.magnolia.module.InstallContextImpl : [0/6 tasks - Magnolia UI Framework (version 5.7.1-SNAPSHOT)]> Field type definition class is different from default one. Expected: [info.magnolia.ui.form.field.definition.CodeFieldDefinition], got: [info.magnolia.ui.form.field.definition.CodeFieldDefinition] in [code]. 2018-07-10 11:04:42,471 WARN info.magnolia.module.InstallContextImpl : [0/6 tasks - Magnolia UI Framework (version 5.7.1-SNAPSHOT)]> Field type factory class is different from default one. Expected: [info.magnolia.ui.form.field.factory.CodeFieldFactory], got: [info.magnolia.ui.form.field.factory.CodeFieldFactory] in [code]. 2018-07-10 11:04:42,473 WARN info.magnolia.module.InstallContextImpl : [0/6 tasks - Magnolia UI Framework (version 5.7.1-SNAPSHOT)]> Field type definition class is different from default one. Expected: [info.magnolia.ui.form.field.definition.DateFieldDefinition], got: [info.magnolia.ui.form.field.definition.DateFieldDefinition] in [date]. ... |