Implement new Magnolia Shell for the new Admincentral (MGNLUI-4540)

[MGNLUI-4607] Improve/Deprecate OverlayLayer API Created: 18/Feb/18  Updated: 14/Sep/18  Resolved: 14/Sep/18

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0

Type: Sub-task Priority: Neutral
Reporter: Aleksandr Pchelintcev Assignee: Mikaël Geljić
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-4614 Integration: simple and complex dialo... Closed
Template:
Date of First Response:
Sprint: Saigon 151, Saigon 152, Saigon 153

 Description   

The interface is pretty poorly designed with a bunch of the method overrides where a fluent API could suffice.

Rough outline:

  • refactor, convert the API to the fluent API
  • break down confirmation callback in order to allow lambdas as ok/ok handlers
  • rename OverlayCloser interface


 Comments   
Comment by Saimir Gasa [ 30/Aug/18 ]

mgeljic, are you currently or in the near future going to be tackling this? 

Comment by Saimir Gasa [ 30/Aug/18 ]

apchelintcev, could you please provide an Acceptance Criteria for this?

Comment by Saimir Gasa [ 30/Aug/18 ]

Team sees issue as necessary for 6.0 Release but it doesn't have enough information to estimate it.

Comment by Mikaël Geljić [ 31/Aug/18 ]

Basically I just demolished/deprecated OverlayLayer in MGNLUI-4540, in favor of either of:

  • Vaadin Notifications
  • AlertBuilder for producing alerts and confirm-dialogs (effectively Vaadin Windows)
  • An upcoming DialogBuilder for opening regular (or light) dialogs (also Vaadin Windows).

Technically:

  • AlertBuilder is a fluent builder-style API (point 1.)
  • Alert and confirm callbacks are passed as Runnables, so they become compatible w/ lambdas/method-refs (point 2.)
  • OverlayCloser is deprecated (despite supported for compatibility); both Notifications and Windows support programmatic #close(), as well as CloseListeners. (point 3.)

All of these end up in a specific, unique div controlled by Vaadin (named something like admincentral-923038437-overlays).
Functionally, this means we drop the notion of attaching a dialog/alert to a specific app or sub-app. Everything is attached to the root application.

I'm moving this ticket to MGNLUI and I'll be using that ticket number then.

Generated at Mon Feb 12 09:18:18 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.