[MGNLUI-4664] Configurable theme and widgetset for new admincentral Created: 02/Oct/18  Updated: 20/Nov/18  Resolved: 23/Oct/18

Status: Closed
Project: Magnolia UI
Component/s: admincentral
Affects Version/s: None
Fix Version/s: 6.0

Type: Improvement Priority: Neutral
Reporter: Roman Kovařík Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 5h
Original Estimate: Not Specified

Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: Resurface theme
Sprint: Saigon 156
Story Points: 3

 Description   

Theme and widgetset is currently hardcoded for the resurface.

As result of this ticket, those are configurable via magnolia properties as in the old admincentral.



 Comments   
Comment by Mikaël Geljić [ 25/Oct/18 ]

Restore widgetset/theme configuration from magnolia.properties

  • For the new admincentral
  • Unlike previous implementation, give precedence to any of the default Vaadin mechanisms (annotated, generated, etc.)
  • Removed hard-coded @Widgetset but kept @Theme("resurface-admincentral") because M5 reads the theme from the same property.

Effectively, this means that we're not making the theme configurable just by property yet, until we phase out the M5 admincentral. Meanwhile, it remains possible to extend our UI class and use another @Theme annotation there.

Comment by Hieu Nguyen Duc [ 25/Oct/18 ]

QA verified on "magnolia-community-demo-bundle-6.0-20181024.140436-209-tomcat-bundle" and "magnolia-enterprise-pro-demo-bundle-6.0-20181025.032539-348-tomcat-bundle". Both works fine.

Generated at Mon Feb 12 09:18:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.