[MGNLUI-4706] Fix tab headers in Messages app Created: 12/Oct/18  Updated: 20/Nov/18  Resolved: 11/Nov/18

Status: Closed
Project: Magnolia UI
Component/s: design
Affects Version/s: None
Fix Version/s: 6.0

Type: Bug Priority: Neutral
Reporter: Mikaël Geljić Assignee: Dai Ha
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0.5d
Time Spent: 3d 1.5h
Original Estimate: Not Specified

Attachments: PNG File Screen Shot 2018-10-25 at 4.51.37 PM.png     PNG File Screen Shot 2018-10-25 at 4.52.52 PM.png     PNG File message-tab-spacing.png     PNG File screenshot-1.png     PNG File screenshot-2.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Resurface polishing
Sprint: Saigon 157, Saigon 158
Story Points: 0.5

 Description   

Tabsheet in the Messages app should work the same way as in all other apps. Can be observed in the Messages app, when there is a message with very loooong title.

  • Regression on text-overflow, there should be a max-width with text ellipsis. Tab is too wide.
    • was implemented with a post-fix commit: 81bca52
  • see spec on MGNLUI-4475 and in Zeplin https://zpl.io/aRYdXRN
  • Spaces between words became a lot wider o__O
  • In Messages/Tasks apps, fix the main (browser) tab "New" label (should be green), and maybe spacing too


 Comments   
Comment by Evzen Fochr [ 25/Oct/18 ]

Proposed solution: remove lines 22-25 from messages-content-app.scss

Comment by Dai Ha [ 25/Oct/18 ]

efochr, remove those line will broke message browser tab header, here is the mockup

that tab header styles should be the same on task app, not sure how it looks like on task app for now.

the problem here is on the same tab-sheet, there are many styles of tab-headers are required.

Comment by Evzen Fochr [ 25/Oct/18 ]

Just tested it, if you remove it -

If you remove just max-width: unset -

So yes you are slightly away from mockup with that spacing, but you are in max-width for tabs (no elypsis for first tab).
If we want that spacing - maybe target it to first element and set larger max width to it too ?
Or do we want larger max width for tabs all over system, or do we need that spacing at all? avongunten

Comment by Oanh Thai Hoang [ 09/Nov/18 ]

While doing review section, PO suggest to make icon and title more spacing

Comment by Hieu Nguyen Duc [ 15/Nov/18 ]

QA on "magnolia-enterprise-pro-demo-bundle-6.0-20181114.174006-589-tomcat-bundle.zip". All good.

Generated at Mon Feb 12 09:19:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.