[MGNLUI-4792] Content importer fails on UI-6, DefaultTaskDetailPresenter lacks mapping Created: 14/Nov/18  Updated: 30/Nov/18  Resolved: 22/Nov/18

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.0
Fix Version/s: 6.0

Type: Bug Priority: Neutral
Reporter: Christoph Meier Assignee: Oanh Thai Hoang
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: 0d
Time Spent: 2d 5h
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-4803 Test task actions with workflow Closed
relates to MGNLUI-4813 Bring compatibility task presenter fo... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Resurface theme
Sprint: Saigon 158
Story Points: 1

 Description   

Approving a task created via Content Importer module fails with exception.

Reproduce:

  • Add the Content Importer module to your bundle; configure magnolia.content.bootstrap.dir accordingly
  • Start bundle
  • Add a bootsrap.xml to the observed directory
    • Task is created and sent to ... messages
  • Assign task to you
  • Try to approve the task => here it fails see stack trace


 Comments   
Comment by Mikaël Geljić [ 14/Nov/18 ]

Not so much content-importer related so it seems.

info.magnolia.ui.admincentral.shellapp.pulse.task.DefaultTaskDetailPresenter is now bound to admincentral M5, so the component mapping is indeed not there in M6; we'd have to adjust the action(s) :#

  • we might consider a "compatibility bridge" there too with a fake impl; cuz those actions might be used in workflow and elsewhere
  • said presenter is extended in workflow (hint hint, more to check)
  • all AbstractTaskAction would previously inject it, since it was in its constructor until last month
Comment by Oanh Thai Hoang [ 22/Nov/18 ]

This PR just supports for running content-importer without error. It doesn't fix the case: going back the list view or refreshing the detail view

For more technical details: Bring up configuration 

<component>
 <type>info.magnolia.ui.admincentral.shellapp.pulse.task.DefaultTaskDetailPresenter</type>
 <implementation>info.magnolia.ui.admincentral.shellapp.pulse.task.NoopTaskDetailPresenter</implementation>
</component>

doesn't bring DefaultTaskDetailPresenter to parameters of action parameters. We need to include it explicitly like FormDialogPresenter See [CompatibilityActionExecutionService|http://example.com

Comment by Dai Ha [ 26/Nov/18 ]

Verified with magnolia-enterprise-pro-demo-bundle-6.0-20181125.035905-719-tomcat-bundle.zip
New node bootstrap file was recognized and new import task was created. Import task executed successfully.

Generated at Mon Feb 12 09:20:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.