[MGNLUI-4803] Test task actions with workflow Created: 19/Nov/18  Updated: 14/Dec/18  Resolved: 22/Nov/18

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0

Type: Task Priority: Neutral
Reporter: Antti Hietala Assignee: Dai Ha
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1d 7h
Original Estimate: Not Specified

Attachments: PNG File Screen Shot 2018-11-20 at 4.37.27 PM.png     PNG File reject_dialog_no_header_no_field_caption.png    
Issue Links:
Relates
relates to MGNLUI-4792 Content importer fails on UI-6, Defau... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: 6.0 requisite
Sprint: Saigon 158, Saigon 159
Story Points: 3

 Description   

Task actions are not tested with workflow.
Most (if not all) of them must have injected a component which is no longer provided in current M6.

via MGNLUI-4792:

info.magnolia.ui.admincentral.shellapp.pulse.task.DefaultTaskDetailPresenter is now bound to admincentral M5, so the component mapping is indeed not there in M6; we'd have to adjust the action(s) :#

  • we might consider a "compatibility bridge" there too with a fake impl; cuz those actions might be used in workflow and elsewhere
  • said presenter is extended in workflow (hint hint, more to check)
  • all AbstractTaskAction would previously inject it, since it was in its constructor until last month


 Comments   
Comment by Dai Ha [ 20/Nov/18 ]

Reject task action is failing due to NPE happens when looping through dialog definitions.

2018-11-20 13:41:20,943 ERROR tral.shellapp.pulse.task.action.AbstractTaskAction: An error occurred while trying to execute task [info.magnolia.module.workflow.jbpm.humantask.HumanTask@70d50590[processData=info.magnolia.module.workflow.jbpm.humantask.ProcessData@4a5fc219,path=/tasks/2018/10/20/1542695688906,id=ee7f5fa0-4249-4296-b068-ff5d12119672,name=publish,status=InProgress,priority=0,requestor=superuser,comment=test,groupIds=[travel-demo-publishers, publishers],actorIds=<null>,actorId=superuser,skippable=false,content={path=/sample-pages, comment=test, isDeletion=false, repository=website, uuid=3686a4ce-91ba-4f55-bfac-a30ff35bc76a, version=1.0, recursive=false, requestor=superuser},results={},creationDate=Tue Nov 20 13:38:59 ICT 2018,modificationDate=Tue Nov 20 13:41:16 ICT 2018,failure=<null>]]
java.lang.NullPointerException: null
	at info.magnolia.ui.admincentral.shellapp.pulse.task.action.RejectTaskAction.lambda$executeTask$0(RejectTaskAction.java:113) ~[magnolia-ui-admincentral-6.0-SNAPSHOT.jar:?]
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174) ~[?:1.8.0_162]
	at java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1359) ~[?:1.8.0_162]
	at java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:126) ~[?:1.8.0_162]
	at java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:498) ~[?:1.8.0_162]
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485) ~[?:1.8.0_162]
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) ~[?:1.8.0_162]
	at java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:152) ~[?:1.8.0_162]
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:1.8.0_162]
	at java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:464) ~[?:1.8.0_162]
	at info.magnolia.ui.admincentral.shellapp.pulse.task.action.RejectTaskAction.executeTask(RejectTaskAction.java:114) ~[magnolia-ui-admincentral-6.0-SNAPSHOT.jar:?]
Comment by Dai Ha [ 21/Nov/18 ]

All task-workflow actions seems work on Task app except the Reject action one. PR incoming to fix that issue.
Some other observations (not related to actions)
+ Open task detail then open another task detail (with the previous one is opening) -> detail header is not updated, actions availabilities are not updated. Workaround is close and open task detail again or refresh page.

Comment by Dai Ha [ 22/Nov/18 ]

Schedule publication works fine.

Comment by Oanh Thai Hoang [ 26/Nov/18 ]

Open task detail then open another task detail (with the previous one is opening) -> detail header is not updated, actions availabilities are not updated. Workaround is close and open task detail again or refresh page.

 PR fixing is introducing: https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/pull-requests/830/overview

Generated at Mon Feb 12 09:20:14 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.