[MGNLUI-4816] Define min. height & max. width for dialogs Created: 22/Nov/18  Updated: 28/Jun/19  Resolved: 27/May/19

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 6.1

Type: Improvement Priority: Neutral
Reporter: Anja von Gunten Assignee: Hieu Nguyen Duc
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 5d 4h 38m
Original Estimate: 3d

Attachments: PNG File Bildschirmfoto 2018-11-22 um 10.34.24.png     PNG File aTry.png     PNG File image (1).png     PNG File image-2018-12-17-10-33-05-701.png    
Issue Links:
Relates
relates to MGNLUI-4884 Optiongroup wraps too quickly despite... Closed
dependency
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: Resurface finalisation
Sprint: Foundation 10, Foundation 11
Story Points: 5

 Description   

Acceptance criteria

  • Dialogs should have a min. height so that - when there is little content - the dialog doesn't look oversized to what's actually shown inside.
  • Dialogs should also have max. width so on a wide screen they don't span all the way from left to right border.
  • Responsive dialogs: Add spacing of 20px form right border when viewport smaller than 1312px (see screenshot)

 

 



 Comments   
Comment by Martin Drápela [ 17/Dec/18 ]

Also for example here, if browser.actions.confirmDeleteFolder.confirmationMessage has no value set:

Comment by Roman Kovařík [ 13/May/19 ]

Verify that this fix doesn't cause blurry dialogs on chrome reported by amanzoni

Comment by Adam Siska [ 13/May/19 ]

rkovarik confirmed, this line does it:

transform: translate(-50%, -50%);

EDIT: and this looks promising:

transform: translate(-50%, -50%) scale(2);

zoom: 0.5;

(see https://stackoverflow.com/questions/31109299/css-transform-translate-50-50-makes-texts-blurry){{}}

Comment by Roman Kovařík [ 13/May/19 ]

translate3d doesn't help?

Comment by Adam Siska [ 14/May/19 ]

translate3d has the same blur effect in my chrome

Comment by Hieu Nguyen Duc [ 14/May/19 ]

asiska I've tried the your snippet but it doesn't work quite right. Clicking on the template select makes the whole viewport shaking.

I keep investigating.

Comment by Aleksandr Pchelintcev [ 14/May/19 ]

re-opening the ticket since investigation is restarted

Generated at Mon Feb 12 09:20:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.