[MGNLUI-4829] Find Bar: Suggestion icons are wrong (part 2) Created: 27/Nov/18 Updated: 18/Dec/18 Resolved: 17/Dec/18 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Antti Hietala | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Not an issue | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
v 6.0 (Snapshot: 2018.11.16 07:00:49) |
||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | Resurface finalisation | ||||||||
| Description |
|
To reproduce:
Icons in the result grid don't match the item type. |
| Comments |
| Comment by Antti Hietala [ 27/Nov/18 ] |
|
Most icon issues were fixed in
|
| Comment by Aleksandr Pchelintcev [ 17/Dec/18 ] |
|
As per UX design only app references themselves should be using svg icons, content icons are resolved via node type icon config, which usually differs from the apps icon. |
| Comment by Aleksandr Pchelintcev [ 17/Dec/18 ] |
|
maybe worth making sure with avongunten and reopen if needed |
| Comment by Anja von Gunten [ 18/Dec/18 ] |
|
apchelintcev ahietala Currently most of the results now show that node content icon (four squares) which is not wrong but also not very meaningful. Ideally we could specify an icon per result group. |
| Comment by Antti Hietala [ 18/Dec/18 ] |
True. I get it now. This is not a Find Bar or Resurface issue. The issue is rather with the icon we set in the app definition, more specifically in the content connector. If we want all story nodes to have the Stories icon (a leaf) then we should rather specify the leaf in the app definition. |