[MGNLUI-4829] Find Bar: Suggestion icons are wrong (part 2) Created: 27/Nov/18  Updated: 18/Dec/18  Resolved: 17/Dec/18

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Antti Hietala Assignee: Aleksandr Pchelintcev
Resolution: Not an issue Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

v 6.0 (Snapshot: 2018.11.16 07:00:49)
Enterprise Edition


Attachments: PNG File Screen Shot 2018-11-27 at 12.38.42.png     PNG File Screen Shot 2018-11-27 at 12.39.08.png    
Issue Links:
Issue split
split from MGNLUI-4796 Find Bar: Suggestion icons are wrong Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Resurface finalisation

 Description   

To reproduce:

  1. Log in.
  2. Put cursor in Find Bar and type "a".
  3. Scroll down to the results.

Icons in the result grid don't match the item type.



 Comments   
Comment by Antti Hietala [ 27/Nov/18 ]

Most icon issues were fixed in MGNLUI-4796 but:

  • it would seem that all jcr content uses jcr app icon (four circles) despite the fact that it has own app with own app icon (e.g. Stories, content tags, marketing tags)
  • also e.g. cookies and groovy content is showing "tools" icon

 

Comment by Aleksandr Pchelintcev [ 17/Dec/18 ]

As per UX design only app references themselves should be using svg icons, content icons are resolved via node type icon config, which usually differs from the apps icon.

Comment by Aleksandr Pchelintcev [ 17/Dec/18 ]

maybe worth making sure with avongunten and reopen if needed

Comment by Anja von Gunten [ 18/Dec/18 ]

apchelintcev ahietala Currently most of the results now show that node content icon (four squares) which is not wrong but also not very meaningful. Ideally we could specify an icon per result group.

Comment by Antti Hietala [ 18/Dec/18 ]

content icons are resolved via node type icon config

True. I get it now. This is not a Find Bar or Resurface issue. The issue is rather with the icon we set in the app definition, more specifically in the content connector. If we want all story nodes to have the Stories icon (a leaf) then we should rather specify the leaf in the app definition. 

Generated at Mon Feb 12 09:20:30 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.