[MGNLUI-4974] Implement keyboard navigation in tabular views. Get shortcut support on par with M5 apps Created: 22/Jan/19 Updated: 08/Jan/20 Resolved: 23/Dec/19 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.2 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Šimon Demočko |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 6d 5.05h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Documentation update required: |
Yes
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Epic Link: | Keyboard shortcuts | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | UI Framework 11, UI Framework 12, UI Framework 13 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Story Points: | 8 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
Other shortcut bindings for custom actions will be implemented in |
| Comments |
| Comment by Šimon Demočko [ 20/Nov/19 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Related docs: 5.7 https://documentation.magnolia-cms.com/display/DOCS57/Keyboard+shortcuts | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Anja von Gunten [ 25/Nov/19 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
apchelintcev sdemocko I guess current ticket is about keyboard shortcuts in grid views right? Here is a full overview of M6 shortcuts https://wiki.magnolia-cms.com/display/UX/M6+Keyboard+navigation Here is a related epic with smaller packages of the above https://jira.magnolia-cms.com/browse/MGNLUI-4934 Maybe we have some overlap, eg. https://jira.magnolia-cms.com/browse/MGNLUI-4557 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Šimon Demočko [ 26/Nov/19 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
cmeier are we sure about SHIFT and CMD? I just tried and it works with SHIFT and arrows. Combining it with CMD does not seem to do anything. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Christoph Meier [ 27/Nov/19 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
Yes, at least for me The shift scenario: The CMD scenario: I operate on OS-X. (But I highly assume that works on other systems too. On Windows use CTRL instead of CMD). P.S. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Šimon Demočko [ 27/Nov/19 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
We have further clarified with avongunten, ldelnevo and rkovarik desired keyboard navigation for grids. I reflected decisions in the Grid table on https://wiki.magnolia-cms.com/display/UX/M6+Keyboard+navigation. The scope of this issue was shown to be larger after clarifying. With rkovarik we narrowed the scope of this issue. Related but out of scope issues were created:
Description of this issue will be modified to reflect agreed amended scope. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Šimon Demočko [ 27/Nov/19 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
cmeier thanks for further clarifying that. I added SHIFT + ML and CMD/CTRL + ML to the documentation and current scope. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Šimon Demočko [ 23/Dec/19 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Persistence of inline edits had to be reimplemented (unexpected scope) since used shortcut add-on broke it. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Šimon Demočko [ 27/Dec/19 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Current implementation triggers shortcut when typing in filter columns. Linking issue | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Comment by Šimon Demočko [ 30/Dec/19 ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Info for DOCS – unless we need to revert the changes in the issue (this we'll know in following days) these will be the changes introduced to docs: All of this stands for behavior in grids / browser sub apps
Might be good to refer to the fact that the app needs to have it's delete action and default action configured for the shortcuts to trigger those. Otherwise nothing happens. It might be also good to note, that though SHIFT + J,K work to select rows, SHIFT + arrows do not (we might fix that later, but it's complicated, so it might stay like this) |