[MGNLUI-5015] Keep CKEditor notifications on top of dialogs Created: 13/Feb/19  Updated: 19/Dec/22  Resolved: 28/Nov/22

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.0, 6.2.26
Fix Version/s: 6.3, 6.2.27

Type: Bug Priority: Neutral
Reporter: Jonathan Ayala Assignee: Mikaël Geljić
Resolution: Fixed Votes: 3
Labels: ckeditor
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 0.5d Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: PNG File Screenshot 2019-02-13 at 09.34.58.png     PNG File Screenshot 2019-02-13 at 16.26.16.png     PNG File browser-doesnt-support.png     PNG File ckeditor-demo-site.png    
Issue Links:
Relates
relation
is related to MGNLUI-5018 Bug when inserting an image into the ... Closed
is related to MGNLUI-6976 CKEditor paste from word removes supe... Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLUI-7643 Implementation Sub-task Closed Mikaël Geljić  
MGNLUI-7644 Review Sub-task Closed Roman Kovařík  
MGNLUI-7645 Pre-Integration QA Sub-task Completed Daniel Alonso  
MGNLUI-7650 QA Sub-task Completed Sang Ngo Huu  
MGNLUI-7651 Backport to 6.2 Sub-task Completed Daniel Alonso  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Release notes required:
Yes
Date of First Response:
Sprint: Nucleus 24
Story Points: 1
Team: Nucleus

 Description   

Currently paste buttons in CKEditor don't work as expected due to a security restriction in browsers. When pressing the button, an alert is shown asking for using a shortcut (CTRL+V) instead.

Steps to reproduce it:

  1. Copy an extract from a word document on the clipboard
  2. In admin central create a basic page and add a text and image component within
  3. When filling the component's dialog, press paste buttons

In Magnolia 6.0/6.2 you will see the message after pressing several times the button as it appears behind the dialog: (update: still the same also in M6.1.4 and M6.2.22)

In Magnolia 5.7 and earlier you will see the following:

Those buttons shouldn't appear anymore.

Additionally, this feature has been added again through a context menu in CKEditor 5 v11.2.0 (no paste buttons anymore). It might be interesting to update CKEditor to version 5 so that editors could make use of both the shortcut and the right-click menu to paste the content.

Notes
Here is an updated screenshot from 6.2.22. Click the button several times and watch the bottom of the screen:

Also if you go to the paste from word demo area for the ckeditor you get the same problem.

Workaround
Paste buttons won't appear by simply replacing a line in our configuration file: 5
From:

{ name: "clipboard",     items: [ "Cut", "Copy", "Paste", "PasteText", "PasteFromWord" ] },

To:

{ name: "clipboard",     items: [ "Cut", "Copy"] },


 Comments   
Comment by Mikaël Geljić [ 16/Nov/22 ]

dialog z-index is 10000, while cke_notifications_area z-index is 9998; might be a quick win indeed, I assume we feel more confident to raise the ckeditor notifications z-index, than reduce the one from dialogs.

The fix would be:

.cke_notifications_area {
  z-index: 10001 !important;
}
Comment by Roman Kovařík [ 21/Nov/22 ]

Discovery done, see the comment above (or below depending on the new sorting option ).

Generated at Mon Feb 12 09:22:23 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.