[MGNLUI-5071] Closing sub app in M5 mode throws error Created: 07/Mar/19  Updated: 05/Mar/21  Resolved: 05/Mar/21

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.0
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Federico Grilli Assignee: Unassigned
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Happens only on M5 mode (reachable e.g. via http://contexPath/.magnolia/admincentral-m5) and when clicking on save button, whereas closing the subapp via tab icon works fine.
Can be reproduced on any content app, e.g. contacts.

A quick debug session showed that at info.magnolia.ui.framework.app.AppInstanceControllerImpl#stopSubAppInstance the instanceId argument didn't match any subapp, hence subAppDetails.context throwing NPE

private void stopSubAppInstance(String instanceId) {
 SubAppDetails subAppDetails = subApps.get(instanceId);
...
 sendSubAppLifecycleEvent(subAppDetails.context, SubAppLifecycleEvent.Type.STOPPED);

The issue was revealed by info.magnolia.integrationtests.uitest.ItemSelectionUITest#verifyContactIsSelectedAfterCreation which has been temporarily ignored (oddly enough on Jenkins the test didn't fail consistently though). Once the issue is resolved, please re-enable the test.



 Comments   
Comment by Roman Kovařík [ 05/Mar/21 ]

Closing this as M5 admincentral is not supported anymore.

Generated at Mon Feb 12 09:22:56 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.