[MGNLUI-5219] New framework: support for root item selection Created: 31/May/19 Updated: 18/Mar/20 Resolved: 27/Feb/20 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 6.0, 6.1 |
| Fix Version/s: | 6.2 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Roman Kovařík | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 3d 58m | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||
| Sprint: | UI Framework 2, UI Framework 10, UI Framework 11, UI Framework 16, UI Framework 17, UI Framework 18 | ||||||||||||||||||||||||||||||||
| Story Points: | 1 | ||||||||||||||||||||||||||||||||
| Description |
|
Vaadin's grid calls items on first level as "root items". Acceptance criteria:
|
| Comments |
| Comment by Roman Kovařík [ 07/Aug/19 ] |
|
Reopened: in multiselection, the root keeps to be selected after you select another item. |
| Comment by Roman Kovařík [ 05/Nov/19 ] |
|
Reopened: root selection is again broken by refactoring. |
| Comment by Šimon Demočko [ 21/Nov/19 ] |
|
Reopened: Selecting an item using spacebar or checkbox on the side has two items selected, the invisible root and the newly selected item. The tests removed here https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/pull-requests/1177/diff#magnolia-ui-framework/src/test/java/info/magnolia/ui/contentapp/browser/TreeViewTest.java seem to have been testing this or related behaviour. rkovarik pointed out we select root when no item is selected, but do not unselect root when a none-root item is selected. (here: https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/magnolia-ui-framework/src/main/java/info/magnolia/ui/contentapp/browser/Browser.java#93) |
| Comment by Federico Grilli [ 28/Nov/19 ] |
|
QA on DX-Core 6.2 (Snapshot: 2019.11.28 09:41:29). |