[MGNLUI-5279] TreePresenter: not beeing sortable by default makes no sense Created: 12/Jul/19  Updated: 23/Aug/19  Resolved: 23/Aug/19

Status: Closed
Project: Magnolia UI
Component/s: app framework
Affects Version/s: 6.0
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Marty Glaubitz Assignee: Simon Lutz
Resolution: Not an issue Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Windows 10


Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Today i struggled with a Content App which was using the Hierarchical Container for a Tree view. I was wondering why the sort order configured in the Content Connector was not respected. Then i found out the beeing sortable by default is disabled for the TreePresenter:

private static final String SAVE_ACTION_NAME = "saveItemProperty";
private static final Logger log = LoggerFactory.getLogger(TreePresenter.class);
private final UiContext uiContext;
private final SimpleTranslator i18n;

private boolean sortable = false; // <- why though?

@Inject
public TreePresenter(TreeView view, ComponentProvider componentProvider, UiContext uiContext, SimpleTranslator i18n) {
    super(view, componentProvider);
    this.uiContext = uiContext;
    this.i18n = i18n;
}

To me this seems odd - since the TreePresenter is infact capable of sorting it's content. So i can't think of a valid reason to disable this for tree views....



 Comments   
Comment by Simon Lutz [ 23/Aug/19 ]

Hi martyglaubitz,

It is set to false by default as there are some areas where the order is relevant, e.g. in the Pages app. You're able to configure it, it is for example available in the Security app. More information is available in the ticket MGNLUI-3326.

I will go ahead and close this issue.

Best regards,
Simon

Generated at Mon Feb 12 09:24:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.