[MGNLUI-5292] Encoding is not properly considered when uploading ZIP archive Created: 20/Jul/19 Updated: 02/Dec/19 Resolved: 25/Jul/19 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.1.1, 6.2 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||
| Sprint: | Release 6.1.1 | ||||||||||||||||||||||||||||
| Story Points: | 2 | ||||||||||||||||||||||||||||
| Comments |
| Comment by Aleksandr Pchelintcev [ 25/Jul/19 ] |
|
asiska what is proper? the proper variant in this case would be the case where the special chars are replaced with dashes. |
| Comment by Mikaël Geljić [ 25/Jul/19 ] |
|
In this case yes, that zip was created (most likely on windows) using CP437; it's usually hard to auto-detect. Commons-compress still tries to detect UTF-8 (even if CP were selected), but I'm not sure it does it the other way around. See https://commons.apache.org/proper/commons-compress/zip.html#Encoding. |
| Comment by Adam Siska [ 25/Jul/19 ] |
|
Discussed it with Mika, didn't get it first time, ticket is closed. |