[MGNLUI-5306] Untie details sub-app implementation from the dialogs (notation- style- and impl- wise) Created: 30/Jul/19  Updated: 26/Aug/19  Resolved: 26/Aug/19

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Aleksandr Pchelintcev Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLUI-4998 Get details sub-app UI on par with 5.... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Epic Link: UI framework: forms, dialogs, content editing
Sprint: UI Framework 3
Story Points: 5

 Description   

Currently for implementation simplicity ContentDetailsuSubApp is implemented by means of DialogHelper utility which effectively binds the sub-app with how dialogs act and look. Under the hood the DialogComponent instance is used in order to display the sub-app.

This results into pain of styling the sub-app differently from the dialogs (and complicates the linked ticket finalisation).

We need to:

  • not use the DialogHelper at least in ContentDetailSubApp. Ideally - phase out the utility completely, because we already have a DialogBuilder.
  • Re-use the relevant parts in CDS that used to be managed by the helper, but compose them differently, use the appropriate style names etc.


 Comments   
Comment by Aleksandr Pchelintcev [ 26/Aug/19 ]

The issue has been fixed as result of the effort done on MGNLUI-4998.

Generated at Mon Feb 12 09:25:13 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.