[MGNLUI-5372] Do not update read-only properties with JCRPropertySet setters Created: 13/Sep/19 Updated: 05/Nov/19 Resolved: 08/Oct/19 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 6.1.2 |
| Fix Version/s: | 6.2 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Epic Link: | UI framework: forms, dialogs, content editing |
| Sprint: | UI Framework 6 |
| Description |
|
By default JcrPropertySet implementation would just write the current values of the properties coming from the binder regardless whether they have been modified or not. This simplifies the update logic but might mess up the properties that are never meant to be written (and hence marked as read-only in the editors). The read-only information should be propagated to the propertyset's descriptors and setter should do nothing if readonly state is set to true. |