[MGNLUI-5444] Release ItemProviderStrategy implementations from the dependency on the parent item provider strategy Created: 24/Oct/19 Updated: 14/Nov/19 Resolved: 12/Nov/19 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.2 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0.25d | ||
| Time Spent: | 0.7h | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Epic Link: | UI framework: forms, dialogs, content editing |
| Sprint: | UI framework 9, UI Framework 10 |
| Story Points: | 8 |
| Description |
|
The bug was uncovered when the complex fields were tested in dialogs: unlike the detail sub-apps where the root item provider strategy is always there, the dialogs don't set one. The complext fields' item prov impls, however, try to inject the parent one and when it is not present - fail. The reason for such injection attempt is that the child editors need to access the parent item/node to resolve the sub-item to bind themselves to. However, instead of injecting the strategy we could change its root API and pass the parent item directly, should it exist! |