[MGNLUI-5568] Inline edit does not persist changes when using GridFastNavigation add-on Created: 17/Dec/19  Updated: 23/Dec/19  Resolved: 23/Dec/19

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Šimon Demočko Assignee: Šimon Demočko
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Epic Link: Keyboard shortcuts

 Description   

Grid FastNavigation add-on seems to only support unbuffered editors. https://vaadin.com/directory/component/gridfastnavigation-add-on 

Inline editor does not persist changes with this add-on. Seems like with the add-on editor saveListeners are not notified of editor saving upon closure. Previously, this was taken care of like this:

getEditor().addSaveListener(event -> datasource.commit(event.getBean())); //in MagnoliaGrid

Investigation needs to take place to figure out:

  • if the add-on cannot be enabled to use buffered editor somehow.
  • if we cannot trigger save event on our own.
  • if we could make use of FastNavigation listeners to emulate a buffered behaviour on our own
    • using
      • addEditorCloseListener
      • addCellEditListener
        • event.getColumnIndex
        • event.getOldData
        • event.getNewData
    • if this path is taken extra care needs to be taken if JCR node renaming based on change of jcrName works afterwards.

 



 Comments   
Comment by Šimon Demočko [ 23/Dec/19 ]

Fixed in MGNLUI-4974. Editor was changed to unbuffered and support for persisting of changes implemented using GridFastNavigation.

Generated at Mon Feb 12 09:27:51 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.