[MGNLUI-5575] Inline edit feature is incompatible with default action set Created: 23/Dec/19 Updated: 23/Dec/19 |
|
| Status: | Open |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Low |
| Reporter: | Šimon Demočko | Assignee: | Šimon Demočko |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Epic Link: | Keyboard shortcuts |
| Description |
|
This has already been documented in the past here https://documentation.magnolia-cms.com/display/DOCS62/Content+view+definition+-+6+UI
Currently, when both are enabled, they work together, but clash.
Development notesThe main problem is that ENTER opens inline editor eagerly on client side, before server shortcut listeners on ENTER can do anything. Since ENTER is not supposed to be the shortcut for inline editing (it is supposed to be "e") a shortcut listener on "e" could check if inline editor was triggered with "e" instead of enter and modify behavior of ENTER depending on this. This was initially experimented with, but it broke some functionality. More experimentation would need to take place or client side changes introduced. Client side changes could also address other issues as well (e.g. MGNLUI-5565)
|