[MGNLUI-562] Replace MGWT's ScrollPanel in MagnoliaTabSheet Created: 15/Jan/13 Updated: 11/Feb/13 Resolved: 23/Jan/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | tablet, user interaction |
| Affects Version/s: | None |
| Fix Version/s: | 5.0 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Mikaël Geljić | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Description |
|
MagnoliaTabSheetViewImpl uses a ScrollPanel from MGWT to scroll content within one tab/or all at once with show all. Supposedly, this was preferred over a plain GWT ScrollPanel because the latter does seem to play nicely with touch (see http://gwt.googleusercontent.com/samples/Showcase/Showcase.html#!CwDockPanel). However the Panel component, as seen on the vaadin sampler, seems to handle touch nicely - it has momentum, bounces, feels native. We should use MGWT for touch events only, not for UI components, because MGWT theme introduces inline styles that interfere with our own styles (e.g. fonts, as seen in SCRUM-1688) |
| Comments |
| Comment by Aleksandr Pchelintcev [ 16/Jan/13 ] |
|
Trivial fix applied in commit #1041fa62a201cbc248810f1e1206653b88d3a545 - changed import of mgwt ScrollPanel to gwt's scrollPanel. |
| Comment by Mikaël Geljić [ 22/Jan/13 ] |
|
Let's just quickly check the scope of this issue, how far we go for now. Indeed GWT's ScrollPanel did the trick, but it doesn't feel that nice with touch:
How about using a SimplePanel + vaadin TouchScrollDelegate as VPanel does it, do you think it would be rather easy or too cumbersome? |
| Comment by Samuli Penttilä [ 25/Jan/13 ] |
|
Reviewed based on commit #20e1a686fa6db650782fc448c14a4968fbf78e46 |