[MGNLUI-5724] Refactor AbstractJcrAction Created: 12/Mar/20 Updated: 05/Mar/21 Resolved: 05/Mar/21 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | framework |
| Affects Version/s: | 6.2 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Michael Duerig | Assignee: | Unassigned |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: | |
| Epic Link: | UI framework implementation |
| Description |
|
AbstractJcrAction has just a single subclass. Also the semantics of its process method is a bit unclear/problematic in the case where no or multiple items are selected. Maybe AbstractJcrAction can be removed entirely and replaced by (a generalisation of) JcrCommandAction. See JcrCommandAction#resolveTargetItems for how multi / empty item selection is handled here.
cc apchelintcev |
| Comments |
| Comment by Roman Kovařík [ 05/Mar/21 ] |
|
Closing as
|