[MGNLUI-5772] Streamline/revisit implementations of I18nAuthoringSupport Created: 26/Mar/20 Updated: 06/Jun/22 Resolved: 04/Apr/22 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 6.2 |
| Fix Version/s: | 6.2.18, 6.3.0 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Adam Siska |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | nucleus | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 0.25d | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
[X]*
I18n works without the current default impl on the classpath (at least in theory if not possible to test)
|
||||||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||
| Epic Link: | Migrate UI FW internals | ||||||||||||||||||||||||||||
| Sprint: | Nucleus 3, Nucleus 5, Nucleus 7 | ||||||||||||||||||||||||||||
| Story Points: | 2 | ||||||||||||||||||||||||||||
| Team: | |||||||||||||||||||||||||||||
| Description |
|
See slack thread for a little bit of backstory. The main concerns we should revisit here include:
To be compatibility module agnostic:
|
| Comments |
| Comment by Šimon Demočko [ 19/Feb/21 ] |
|
Return to this when locales for different content will be needed (except for JCR), since MultiSiteI18nAuthoringSupport is pseudo-generic. Also, the DefaultI18NAuthoringSupport is currently in compatibility module |
| Comment by Roman Kovařík [ 10/Mar/22 ] |
|
For release notes: These methods of I18nAtuhoringSupport (deprecated since Magnolia 6.0 or longer) were removed:
Custom usages of createI18NURI method can be replaced by I18nContentSupport#createI18NURI(Node node, Locale locale) ( The other methods are still implemented by DefaultII18nAuthoringSupport until the ui-framework-compatibility is unbundled (you can cast I18nAtuhoringSupport to DefaultI18nAuthoringSupport and access these methods).
|
| Comment by Adam Siska [ 15/Mar/22 ] |
|
Reopened due to failing dx-core int. tests (PR reverted): |
| Comment by Roman Kovařík [ 21/Mar/22 ] |
|
Discovery Completed: pages app needs to be recompiled against these UI changes. |
| Comment by Adam Siska [ 01/Apr/22 ] |
|
For the record / in progress notes: We've lost MultiSiteI18nAuthoringSupport config in /server/i18n/authoring/class (while installing instance you can see: Magnolia Multisite Module 2.1.3-SNAPSHOT Property "class" was expected to exist at /server/i18n/authoring with value "info.magnolia.ui.framework.i18n.DefaultI18NAuthoringSupport" but has the value "info.magnolia.ui.framework.i18n.BasicI18NAuthoringSupport" instead. ) Options: DoD: I18n works without the current default impl on the classpath (at least in theory if not possible to test) BasicI18NAuthoringSupport class needs default (no-argument) constructor to work with ProxyFactory during providing component by GuiceComponentProvider /** * Default constructor for class to be extendable by proxy class * during resolving the component by GuiceComponentProvider. */ BasicI18NAuthoringSupport() { this(null, null); } |