[MGNLUI-5787] Provide consistent behavior when Form Dialog is closed Created: 02/Apr/20  Updated: 08/Apr/20  Resolved: 03/Apr/20

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.1

Type: Task Priority: Neutral
Reporter: Rishab Dhar Assignee: Rishab Dhar
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Sprint: UI Framework 21
Story Points: 2

 Description   

The OpenDialogAction currently binds the CloseHandler only to the FormView. This works fine, as long as the user clicks the Cancel button to close the dialog. However, if the user clicks the button on the top right of a dialog to close the dialog, the custom code for handling closing of a dialog is never triggered.

Steps to reproduce

  • Edit a page in the pages app
  • Add a component
  • In the add component dialog click next
  • Click the button to close the dialog (don't click cancel!)

Observed behaviour

The action bar still refers to the component that was added and then cancelled (it shows "component")

Expected behaviour

The action bar should refer to the selected area (it should show "area"). Same as when the add component dialog is cancelled via the cancel button instead of the button.



 Comments   
Comment by Michael Duerig [ 07/Apr/20 ]

rdhar I tried to verify the fix but couldn't figure it out. Could you add to the issue description:

  • How to reproduce
  • Acceptance criteria

Also, would it be hard to add a unit test?

 

Generated at Mon Feb 12 09:30:02 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.