[MGNLUI-5867] Message Banner should be clean up Created: 15/May/20  Updated: 15/May/20

Status: Open
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.1, 6.2
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Oanh Thai Hoang Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Message Banner should be clean up


Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

Following discussion about NPE throwing when using Shell.showError

Here are some improvement suggestions:

  • Deprecated #showError and #showNotification API in shell. See here
  • The Banner component deserves cleanup.
    • Remove all of these Objects#requireNonNull and Preconditions#checkArgument: null values should become empty strings gracefully. If we want to have such checks, they should be on MessagesManager level, not UI component.
    • remove the #setId on line 135

Generated at Mon Feb 12 09:30:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.