[MGNLUI-5892] I18nisation of search results broke file-based search result suppliers Created: 22/May/20 Updated: 25/May/20 Resolved: 25/May/20 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 6.2.1 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Critical |
| Reporter: | Ilgun Ilgun | Assignee: | Unassigned |
| Resolution: | Not an issue | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 5m | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
To Reproduce: 1)
2)
DEV Hints:
|
| Comments |
| Comment by Roman Kovařík [ 23/May/20 ] |
|
Looking at https://git.magnolia-cms.com/projects/ADDON/repos/external-dams/browse/magnolia-external-dam/src/main/java/info/magnolia/external/dam/search/categories/ExternalDamSearchResultSupplier.java#57 it's using name as label. If you check info.magnolia.periscope.operation.OperationDefinitionRegistry#newMetadataBuilder, it's using name as id strategy, so the name of the YAML definition and the supplier should match. Also looking at info.magnolia.external.dam.search.categories.ExternalDamSearchResultSupplierStrategy#construct, it completely ignores the name. |
| Comment by Aleksandr Pchelintcev [ 25/May/20 ] |
|