[MGNLUI-5925] Improve API for adding actions to dialog footers Created: 05/Jun/20  Updated: 15/Oct/20

Status: Open
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Šimon Demočko Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: ui-devx-impr
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-5951 Restrict green button styling in edit... Open
dependency
depends upon MGNLUI-5924 Clarify guidelines for styling of dia... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

Depends on: MGNLUI-5924. Once it sets clear expectations API should be addressed to reflect this, cause it mixes multiple semantics and does not allow for easy adding of predictably styled buttons. 

Acceptance criteria: 

  • Close/Cancel could use more built-ins, shouldn't need to be declared as an "action". The one opening the Dialog (say via DialogBuilder) should know if anything has to be done upon closing (via #withCloseListener). (from this comment)
  • ActionButton should be made agnostic of button styling (will likely be handled sooner w/ MGNLUI-5951)
  • EditorDialogLayout API should be simplified. Just add action. Primary and secondary slot (left buttons, right buttons) is confusing - mixes with semantics of primary-button and secondary-button which are styles currently applied to committing (primary, green) and everything else. Also there is another style in Resurface theme: "primary" and "secondary", which appears to overlap semantically w/ primary-button, secondary-button.

Generated at Mon Feb 12 09:31:24 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.